Dock the keyboard hide button to the right side of the screen #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamthomasbishop could you take a look at this PR and share if you have any comments? Related WPiOS branch is |
|
@pinarol Looking good! I have a couple minor notes:
Details:
|
|
Hi @iamthomasbishop ,
|
|
Looks great, @pinarol! |
5 tasks
This reverts commit f8935b4.
marecar3
approved these changes
Jan 23, 2019
| @@ -7,13 +7,15 @@ import React from 'react'; | |||
| import Svg, { G, Rect, Path } from 'react-native-svg'; | |||
| import { TouchableOpacity } from 'react-native'; | |||
|
|
|||
| import styles from './keyboard-hide-button.scss'; | |||
|
|
|||
| type PropsType = { | |||
| onPress: void => void, | |||
| }; | |||
|
|
|||
| const KeyboardHideButton = ( props: PropsType ) => ( | |||
There was a problem hiding this comment.
that sounds good @marecar3
|
Hey @marecar3, this is ready for another look. |
|
Hey @pinarol |
daniloercoli
added a commit
that referenced
this pull request
Jan 24, 2019
…rg-mobile into issue/372-add-title-to-gutenberg-mobile * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Make sure to use `setContent` when initializating the GlueCode Dock the keyboard hide button to the right side of the screen (#480) RNAztecView: Removing branch spec from podspec Moving RNTAztecView.podspec to the gutenberg-mobile root dir. Aztec iOS: Force send height information to JS after pasting text # Conflicts: # gutenberg # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
daniloercoli
added a commit
that referenced
this pull request
Jan 25, 2019
…rg-mobile into issue/372-add-enter-key-detection-to-Title-block * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Update bundle bump aztec android to v1.3.18 (#498) Update GB hash [Android] - Make sure mContentChanged has the correct value when asking content from the React side. This was necessary since the call to retrieve content and title are separate on Android. The HTML editor background is now white. Make sure to use `setContent` when initializating the GlueCode Dock the keyboard hide button to the right side of the screen (#480) RNAztecView: Removing branch spec from podspec Moving RNTAztecView.podspec to the gutenberg-mobile root dir. Aztec iOS: Force send height information to JS after pasting text # Conflicts: # gutenberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #350
This PR docks the keyboard hide button to the right side of the screen. Depends on WordPress/gutenberg#13415
Android:
iOS:
To Test
Testing prerequisites
For WPiOS
Checkout the PRs branch to any arbitrary folder and cd .. to it
run yarn install, yarn start
Open XCode WPiOS on the latest develop
Clean build folder on Xcode, and then run the app
For WPAndroid
open grade.properties at WordPress-Android folder
add wp.BUILD_GUTENBERG_FROM_SOURCE = true to grade.properties
checkout the PRs branch in the subrepo of WordPress-Android repo
cd to WordPress-Android/libs/gutenberg-mobile
run yarn install, yarn start
yarn wpandroid on a separate terminal in the same directory
Test steps
Check with different blocks and verify keyboard hide button is docked to the right side of the screen while other buttons can be scrolled horizontally
Verify also there's no UI anomaly due to #480 (comment)